tools: run CI with shared libs on GHA #60121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And introduce a
nix.shellfile which IMO can greatly improve the onboarding of new devs: if installing Nix is an option for them, they don't need to figure out which tools and lib to install and pollute their $PATH with those, they can simply let Nix create a sandboxed environment that's guaranteed to compilenode(at least on the platforms we can test, i.e. Linux and macOS, and likely on all platforms compatible with Nix).Regarding the maintenance burden of adding this, I have to maintain it whether this PR lands or not, and so far (I've been using this locally for the past 6 months) it's not been a lot of work, so I'd be happy to take care of it.